(REF) Convert dynamic translations from ts() to _ts()

[totten]

Overview

The ts() function is supposed to be used for literal strings (e.g. ts('Hello world')) rather than dynamic strings (ts($message)). This practice ensures that the scanner (civistrings) is able to identify the strings. The scanner emits warnings about nonconformant invocations.

However, there are a handful of cases where we really want dynamic strings -- and where the warning is unnecessary.

Inspired by discussion of civicrm/civicrm-buildkit#784.

Before

Ex: For the Angular integration, it needs to run ts() for all the JS strings. This loops over a statement like:

$translated = _ts($string, [
  'domain' => [$module['ext'], NULL],
]);

This provokes a warning in civistrings:

$ civistrings Civi/Angular/Manager.php
[warn] first argument of ts() call is no string. (Civi/Angular/Manager.php:316)

After

civistrings is pretty chill.

Comments

• I fixed warnings for the dynamic ts() calls where it seemed structurally appropriate.
• There are still some other files which have warnings for other reasons (e.g. maybe civistrings misjudges the lines, or maybe there's a weird mix of dynamic/static elements).

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I initially thought the name _ts too similar to ts and too easily confused, but the underscore is a pretty standard convention, so, ok.