Why? #26588
Merged
Why? #26588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
jenkins retest this please |
|
Maybe someone just needed to express how they feel about notes? |
|
I just spent an hour writing a detailed, 10 paragraph review of every facet of this PR, then immediately decided to overwrite it with this: |
|
But did you look at the review guidelines? The review criteria are:
|
|
If anyone is curious, the overwrite line used to have an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Why?
Before
Why?
After
I'm none-the-whyser, but there's less why.
Technical Details
Look at the next line.
Comments