Cleanup Email Invoice form to remove longest ever field label #26533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -32,3 +32,7 @@ | |||
| <p>{ts}You can send your email as a simple text-only message, as an HTML formatted message, or both. Text-only messages are sufficient for most email communication, and some recipients may prefer not to receive HTML formatted messages.{/ts}</p> | |||
| <p>{ts}HTML messages have more visual impact, allow you to include images, and may be more readable if you are including links to website pages. However, different email programs may interpret HTML formats differently, so use this option cautiously unless you have a template format that has been tested with different web and desktop email programs.{/ts}</p> | |||
| {/htxt} | |||
|
|
|||
| {htxt id="id-email_comment"} | |||
| {ts}If you would like to add personal message to email please add it here. (If sending to more then one receipient the same message will be sent to each contact.){/ts} | |||
There was a problem hiding this comment.
Not a blocker since this is the same as the original, but there's two typos and one grammar wrong it is.
But otherwise looks good.
There was a problem hiding this comment.
That is pretty bad, have replaced with new text. I closed this by accident and don't think I have the power to re-open - but can you?
Also the email message thing doesn't work at all, but I'll fix that in a new PR.
There was a problem hiding this comment.
Apparently I do.
And yeah I noticed the additional message didn't seem to do anything.
There was a problem hiding this comment.
Now it will work
b23178b to
d0bc241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Also changed from_email to select2 while I was in there and clarified the subject label, plus a little light cleanup.
Before
After