Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.1] Don't pass null to strtoupper in getDynamicCharacters #26508

Merged
merged 1 commit into from
Jun 11, 2023

Conversation

braders
Copy link
Contributor

@braders braders commented Jun 11, 2023

Overview

Don't pass null to strtoupper in CRM_Utils_PagerAToZ::getDynamicCharacters

Before

Mailings (and possibly other sortable entities) are allowed to be saved without a name. When visiting the "Find mailings" page, this error was triggered for each row without a name:

Deprecated function: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in CRM_Utils_PagerAToZ::getDynamicCharacters() (line 100 of [...]/web/sites/all/modules/civicrm/CRM/Utils/PagerAToZ.php).

After

We pass an empty string instead of null to keep PHP happy.

@civibot
Copy link

civibot bot commented Jun 11, 2023

(Standard links)

@civibot civibot bot added the master label Jun 11, 2023
@colemanw colemanw merged commit 655c7e0 into civicrm:master Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants