Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - Enable search operators to be exposed on the form #26496

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jun 9, 2023

Overview

Following on #26066 this allows search operators to be selectable on the form by the end-user.

Before

Search operator could be selected on the back-end when composing a form.

After

Search operator can be exposed to the form.

image

@civibot
Copy link

civibot bot commented Jun 9, 2023

(Standard links)

@colemanw colemanw force-pushed the afformExposeOperators branch from fb86b78 to 64afffa Compare June 9, 2023 18:55
@allinappliadmin
Copy link
Contributor

Coleman, that sounds great. How does it look like on the front side? How does one choose the operator? Is there a drop-down or a tooltip to say which operators can be used (= > < ...)? I'll test as soon as possible in the next coming hours/day./

@colemanw
Copy link
Member Author

@allinappliadmin on the front-end form it shows the operator dropdown attached to the left of the input, like this: (screenshot from the demo site):

image

@allinappliadmin
Copy link
Contributor

(probably a very odd question): is there a way to apply this patch quickly to the 10 files? Would it be 'git apply'?

@colemanw
Copy link
Member Author

colemanw commented Jun 12, 2023

@allinappliadmin you can download any patch from GitHub by adding .diff to the end of the url: https://github.com/civicrm/civicrm-core/pull/26496.diff

And then you can apply it locally like

cd path/to/civicrm
wget https://patch-diff.githubusercontent.com/raw/civicrm/civicrm-core/pull/26496.diff
patch < p1 26496.diff

@allinappliadmin
Copy link
Contributor

Do I also need to apply this patch? I'm on version 5.62.0? Patching has been a mess. Is it on the demo?

@colemanw
Copy link
Member Author

@allinappliadmin
Copy link
Contributor

it works perfectly as expected. It will be of a great help.
image

@allinappliadmin
Copy link
Contributor

on which version is it on prod? 5.64?

@colemanw colemanw merged commit fc76317 into civicrm:master Jun 12, 2023
@colemanw colemanw deleted the afformExposeOperators branch June 12, 2023 15:32
@colemanw
Copy link
Member Author

Thanks for the review @allinappliadmin. Yes it will be in 5.64.

@larssandergreen
Copy link
Contributor

@colemanw Looks like a regression from this one, issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants