Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

present friendlier error message if petition cannot be displayed. #26446

Merged
merged 1 commit into from
Jun 5, 2023
Merged

present friendlier error message if petition cannot be displayed. #26446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CRM/Campaign/Form/Petition/Signature.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,10 @@ public function preProcess() {
CRM_Core_Error::statusBounce(ts('Petition doesn\'t exist.'));
}
if ($this->petition['is_active'] == 0) {
CRM_Core_Error::statusBounce(ts('Petition is no longer active.'));
$this->assign('isActive', FALSE);
}
else {
$this->assign('isActive', TRUE);
}

//get userID from session
Expand Down
57 changes: 30 additions & 27 deletions templates/CRM/Campaign/Form/Petition/Signature.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,34 +21,37 @@
<div class='clear'></div>
{/if}

<div id="intro" class="crm-section">{$petition.instructions}</div>
<div class="crm-block crm-petition-form-block">

{if $duplicate == "confirmed"}
<p>
{ts}You have already signed this petition.{/ts}
</p>
{/if}
{if $duplicate == "unconfirmed"}
<p>{ts}You have already signed this petition but you still <b>need to verify your email address</b>.{/ts}<br/> {ts}Please check your email inbox for the confirmation email. If you don't find it, verify if it isn't in your spam folder.{/ts}</p>
{/if}
{if $duplicate}
<p>{ts}Thank you for your support.{/ts}</p>
{if $is_share}
{include file="CRM/Campaign/Page/Petition/SocialNetwork.tpl" petition_id=$survey_id petitionTitle=$petitionTitle}
{/if}
{if ! $isActive}
<p>{ts}This petition is no longer active.{/ts}</p>
{else}
<div class="crm-section crm-petition-contact-profile">
{include file="CRM/UF/Form/Block.tpl" fields=$petitionContactProfile hideFieldset=true}
</div>

<div class="crm-section crm-petition-activity-profile">
{include file="CRM/UF/Form/Block.tpl" fields=$petitionActivityProfile hideFieldset=true}
</div>
<div id="intro" class="crm-section">{$petition.instructions}</div>
<div class="crm-block crm-petition-form-block">

<div class="crm-submit-buttons">
{include file="CRM/common/formButtons.tpl" location="bottom"}
</div>
{if $duplicate == "confirmed"}
<p>
{ts}You have already signed this petition.{/ts}
</p>
{/if}
{if $duplicate == "unconfirmed"}
<p>{ts}You have already signed this petition but you still <b>need to verify your email address</b>.{/ts}<br/> {ts}Please check your email inbox for the confirmation email. If you don't find it, verify if it isn't in your spam folder.{/ts}</p>
{/if}
{if $duplicate}
<p>{ts}Thank you for your support.{/ts}</p>
{if $is_share}
{include file="CRM/Campaign/Page/Petition/SocialNetwork.tpl" petition_id=$survey_id petitionTitle=$petitionTitle}
{/if}
{else}
<div class="crm-section crm-petition-contact-profile">
{include file="CRM/UF/Form/Block.tpl" fields=$petitionContactProfile hideFieldset=true}
</div>

<div class="crm-section crm-petition-activity-profile">
{include file="CRM/UF/Form/Block.tpl" fields=$petitionActivityProfile hideFieldset=true}
</div>

<div class="crm-submit-buttons">
{include file="CRM/common/formButtons.tpl" location="bottom"}
</div>
{/if}
{/if}

</div>