dev/core#3815 Set options_per_line to zero when changing Custom Field html_type #26415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
|
Thanks @larssandergreen ! I could reproduce the bug and while I agree the fix is a bit of a workaround, it's annoying enough for users imo that we should merge a quickfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See issue.
Ideally, this would be fixed at the template level, but there are a lot of different tpls that display custom fields and I don't think it makes sense to try to change each one of them. This fix just clears options_per_line in the custom fields form when changing the html_type away from Radio or CheckBox. Not ideal as you can still set options_per_line via API and you lose the options per line if you change the html_type from, for example, Radio to Select and back to Radio, but this is an improvement.
Before
Options per line still has a value when it is hidden.
After
Options per line is cleared when it is hidden.