crmMoney filter - allow coercing locale

[MegaphoneJon]

Overview

This adds a crmMoney filter to tokens, comparable to crmDate, for coercing money into a particular format.

Before

You couldn't force money to render a particular way in a message template.

After

Now you can.

Comments

This needs documentation, which I'll do when this is merge-ready.

Slightly out of scope, but there's a not in Civi/Token/TokenProcessor that says // TODO: Move this to StandardFilters. This doesn't quite work, but with a bit of tweaking, that if block can be removed from TokenProcessor.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@MegaphoneJon this feature already exists - check testContributionRecurTokenRaw (which failed here)

Which field is it not working for you on?

[MegaphoneJon]

I'll look tomorrow where it failed for me - I still think the ability to coerce a particular l10n is valuable, though if folks disagree I could put it in an extension.

I need to file a separate bug report, but at least on the master branch, "Amount" is appearing in the token browser when creating a letter on contributions, but it refers to the contribution_recur.amount.

[eileenmcnaughton]

@MegaphoneJon yeah that amount IS a field that COULD be available to contributions - but is obviously confused with total_amount very easily

I think there might be another PR @samuelsov put up (open or closed?) adding language to the crmMoney function somewhere

[eileenmcnaughton]

I'm merging this because it is consisent with the smarty function which seems to be our goal.

But just noting that we have some other fixes in the same release that deal with money & locale & remove the need for this when using workflow message translations (I hope)

[eileenmcnaughton]

@MegaphoneJon I think you were going to document as a follow up? I think we might be either seriously out of date with or entirely missing documentation on token filters.....

[MegaphoneJon]

It's true, the best documentation is a Stack Exchange post I made - which is good, because I probably reference it more than anyone.

I'll get some docs started.