Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF][PHP8.2] Avoid unnecessary property in WebsiteTest #26369

Merged
merged 1 commit into from
May 29, 2023
Merged

[REF][PHP8.2] Avoid unnecessary property in WebsiteTest #26369

merged 1 commit into from
May 29, 2023

Conversation

braders
Copy link
Contributor

@braders braders commented May 29, 2023

Before

contactID was used as a dynamic property. Dynamic properties are deprecated in PHP 8.2.

After

A standard variable works just as well, without triggering a deprecation notice.

@civibot
Copy link

civibot bot commented May 29, 2023

(Standard links)

@civibot civibot bot added the master label May 29, 2023
@braders
Copy link
Contributor Author

braders commented May 29, 2023

Jenkins, test this please

@demeritcowboy demeritcowboy merged commit dff771a into civicrm:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braders @demeritcowboy