dev/core#4298 - respond with 400 not 500 errors if wrong params passed to CiviMail urls

[ufundo]

See: https://lab.civicrm.org/dev/core/-/issues/4298

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[ufundo]

just updated for the style complaints

[totten]

• https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/400
• https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/500

I'm not certain about the use-case in which there's a functional distinction, but (going by the specs generally) -- these conditions do look more like a 400 than a 500 👍 .

[larssandergreen]

I think this makes sense and it would be a nice improvement to remove these unhelpful errors from logs.

[demeritcowboy]

I'm not certain about the use-case in which there's a functional distinction

One nice thing is with this change it no longer appears in the logs, flooding them with junk. As an admin 500 errors are something you might want to look into, but 400 is almost always bots.