Minor cleanup on function #26217
Merged
Minor cleanup on function #26217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
1d72b42 to
4b2d70c
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
May 14, 2023
I checked core & universe & this is not otherwise called so I make it protected. I checked civicrm#26217 that the is_array check is redundant & changed the one place to call it to not call when empty
The primary goal here was to check that it ALWAYS returns an array. It does, so I added a type hint. I also confirmed that - it is not called from universe - it is not called with no primaryParticipantID - it is not called with excludeCancel set for false so I did some deprecating. Lastly there was code to handle there being no cancelStatus - assigning a variable cancelID of 0 as a fallback. But, it was not being used - so I fixed it to cast-to-int.
4b2d70c to
ea8ca0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The primary goal here was to check that it ALWAYS returns an array. It does,
so I added a type hint.