Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/hide billing name/address on event confirm based on if they're set instead of a magical collection of booleans #26181

Merged
merged 1 commit into from
May 9, 2023

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented May 9, 2023

Overview

If we have data for billing name/address then it should be fine to display independently of any billing mode / paylater etc. If we don't have billing data we shouldn't show an empty header.

Before

image

After

image

Technical Details

Comments

…et instead of a magical collection of booleans
@civibot
Copy link

civibot bot commented May 9, 2023

(Standard links)

@civibot civibot bot added the master label May 9, 2023
@demeritcowboy demeritcowboy merged commit a44a1dd into civicrm:master May 9, 2023
@mattwire mattwire deleted the confirmeventmsg branch May 9, 2023 19:35
@mattwire
Copy link
Contributor Author

mattwire commented May 9, 2023

Thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants