Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer - Ensure mapping ID is set in all places using import templates #26108

Merged
merged 1 commit into from
May 4, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

This fixes the missing update saved mapping option when using a template

I think I changed the way the metadata was a few times & so it is a bit confusing - but this ensures it is set in the place MapField is expecting it to be

  • against 5.61 as the rest of import templates is in there - this is just an issue we hit in live testing

This fixes the missing update saved mapping option when using a template

I think I changed the way the metadata was a few times & so it is
a bit confusing - but this ensures it is set in the
place MapField is expecting it to be
@civibot
Copy link

civibot bot commented Apr 25, 2023

(Standard links)

@civibot civibot bot added the 5.61 label Apr 25, 2023
wmfgerrit pushed a commit to wikimedia/wikimedia-fundraising-crm that referenced this pull request Apr 25, 2023
https: //github.com/civicrm/civicrm-core/pull/26108

Bug: T303986

Change-Id: I79f3265e838c9a5523fd3898b97ef82a9d4d95b8
@eileenmcnaughton
Copy link
Contributor Author

test this please

@totten
Copy link
Member

totten commented May 4, 2023

Note from discussion on MM:

(totten) on first blush, 26108 looks innocent. i'm not sure i understand what it's fixing. was there a discussion somewhere leading to it?
(eileen) yeah - it's a new feature that we are really just putting through it's paces now & we wound up having to add that to get it to work for us - no-one else is likely to have used / tested it more than rudimentary

Since the change is pretty isolated and only relates to this new bit, I'm flagging MOP.

@totten totten changed the title Ensure mapping id is set in all places using import templates Importer - Ensure mapping ID is set in all places using import templates May 4, 2023
@seamuslee001 seamuslee001 merged commit 28559c8 into civicrm:5.61 May 4, 2023
@seamuslee001 seamuslee001 deleted the import_template branch May 4, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants