Clarify entityID
types in Merger class
#26003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Clarify
entityID
types in Merger classBefore
As a carry over from when the
getTree
function was shared there is a lack of clarity about the type of$entityID
- this is because in the shared usage it could also be NULLAfter
The IDs are coming from the
getRowsElementsAndInfo
so I added typing to where that function receives the values & cast the values in all the places that call it (except the tests which will tell us if they are not already the right type...)Technical Details
Comments
Anything else you would like the reviewer to note