Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify entityID types in Merger class #26003

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Clarify entityID types in Merger class

Before

As a carry over from when the getTree function was shared there is a lack of clarity about the type of $entityID - this is because in the shared usage it could also be NULL

After

The IDs are coming from the getRowsElementsAndInfo so I added typing to where that function receives the values & cast the values in all the places that call it (except the tests which will tell us if they are not already the right type...)

image

image

Technical Details

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented Apr 4, 2023

(Standard links)

@eileenmcnaughton eileenmcnaughton merged commit 46428b9 into civicrm:master Apr 5, 2023
@eileenmcnaughton eileenmcnaughton deleted the dedupe_strict branch April 5, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants