🥚 Payment API creates Activity with subject: "$x Offline Payment for Contribution" even when a payment was captured online

[agileware-justin]

Overview

Payment API creates Activity with subject: "$x Offline Payment for Contribution" even when a payment was captured online.

This change simply removes the word "Offline" so that it works for describing both online and offline payments.

Before

When the recordPaymentActivity function is called, the addActivityForPayment function has the word "Offline" hard coded for the Activity subject, irrespective of how the payment was created.

After

The word "Offline" is removed, so when the Activity is created it still describes both online and offline payments.

Technical Details

Comments

Ideally the generic "Contribution" would also be set in recordPaymentActivity to refer to Membership, Event or Contribution. For Events, it will use the Event Title but for everything else just uses: "Contribution".

Agileware Ref: CIVICRM-2120

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Thanks @agileware-justin - the test needs updating but i think this can be merged once it is

CRM_Contribute_Form_AdditionalPaymentTest.testMultiplePaymentForPartiallyPaidContribution

Failing for the past 1 build (Since #1556 )

Took 0.32 sec.

Stacktrace

CRM_Contribute_Form_AdditionalPaymentTest::testMultiplePaymentForPartiallyPaidContribution
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'$ 50.00 - Offline Payment for Contribution'
+'$ 50.00 - Payment for Contribution'
/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Form/AdditionalPaymentTest.php:182

/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:229

/home/homer/buildkit/extern/phpunit8/phpunit8.phar:1721

CRM_Contribute_Form_AdditionalPaymentTest.testMultiplePaymentForPartiallyPaidContribution

Failing for the past 1 build (Since #1556 )
Took 0.32 sec.
Stacktrace
CRM_Contribute_Form_AdditionalPaymentTest::testMultiplePaymentForPartiallyPaidContribution
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'$ 50.00 - Offline Payment for Contribution'
+'$ 50.00 - Payment for Contribution'

/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Form/AdditionalPaymentTest.php:182
/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:229
/home/homer/buildkit/extern/phpunit8/phpunit8.phar:1721

[agileware-justin]

Thanks @eileenmcnaughton and done. Happy Easter too 😄 🥚