Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Don't have null values for required fields in Case test fixture #25983

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Apr 2, 2023

Overview

The fields get created as NULL, which doesn't make sense for start_date, and at least on the form subject is required.

I don't think this is used much - tests generally create their own case - but this is more realistic data.

@civibot
Copy link

civibot bot commented Apr 2, 2023

(Standard links)

@civibot civibot bot added the master label Apr 2, 2023
@demeritcowboy demeritcowboy changed the title [WIP] [NFC] Don't have null values for required fields in Case test fixture Apr 2, 2023
@eileenmcnaughton
Copy link
Contributor

Yeah it seems to be loaded in loadAllFixutres() so it is at least not unused

@eileenmcnaughton eileenmcnaughton merged commit 3cf36e6 into civicrm:master Apr 2, 2023
@demeritcowboy demeritcowboy deleted the casejson branch April 2, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants