Fix enotice when using Civi-import

[eileenmcnaughton]

Overview

Fix enotice when using Civi-import

Before

When Civi-import is enabled and the there is an attempt to save an import configuration which includes Soft Credit fields e-notices appear and the Soft credit fields are not saved to civicrm_mapping_field. This is actually a cosmetic rather than functional issue as the values in civicrm_mapping_field and not the primary information source for mappings when Civi-Import is enabled. They are synced to the primary source - which is the import_mappings key in the civicrm_user_job.metadata field. We don't necessary want to keep this sync forever - but while it exists it should work....

After

E-notices fixed, it saves

Technical Details

The underlying problem we are hacking around is that we use api syntax (with dots between entity & field names) with the import code but the QuickForm hierarchical Select element does not support the dots (which I think break it's js). On the QuickForm layer we swap them out for __ & then back again but on the angular layer we keep the dots & save the values to the more sophisticated data structure in the metadata

Comments

Not new to this PR but I do wonder if my js structure here and here is at risk of Quickform submit starting before the js has saved the job. Recommendations welcome on it

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Ok, looks good and is low-risk