SearchKit - Pass entire record into checkAccess
#25969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For efficiency it's best to pass all available data into the `checkAccess` action to avoid unnecessary db lookups. This ensures the full record is passed in when checking access before enabling in-place edit.
|
(Standard links)
|
|
Thanks @colemanw this worked for me - putting up a PR with the change based on it |
|
Linking this to its regression: https://lab.civicrm.org/dev/core/-/issues/4483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Efficiency tweak for SearchKit
Technical Details
For efficiency it's best to pass all available data into the action to avoid unnecessary db lookups. This ensures the full record is passed in when checking access before enabling in-place edit.