[REF][PHP8.2] Declare properties directly on CRM_Core_Form_EntityFormTrait

[braders]

Overview

Declare properties directly on CRM_Core_Form_EntityFormTrait, rather than (inconsistently) on the classes which use it.

Before

The entityFields property was declared individually on many classes which use CRM_Core_Form_EntityFormTrait, but not all of them. Additionally the large docblock was repeated many times, increasing the chance of inconsistent documentation occuring in future.

The metadata property was always being written to as a dynamic property, causing tests to fail on PHP 8.2.

After

The entityFields and metadata properties are explicitely declared on the CRM_Core_Form_EntityFormTrait.

Comments

I think there may be a small backwards compatiability risk here, if third-party extensions are using CRM_Core_Form_EntityFormTrait, but have declared entityFields or metadata as public properties (although I've not actually tested what would happen in this scenario)

There is still a _BAOName property to tackle, which I'll look at seperately.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Thanks @braders I think the risk you described is very low given the usual copy-paste development style, they would have been copied over as protected