(NFC) Version Check Test - Fix multi-user and concurrent execution #25909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small change to the way the tests run. It doesn't change the meaning of the test. Before ------ * Writes example file to `/tmp/versionCheckTestFile.json`. * File left behind at end of test. * If two users runs the same test at different times, they could interfere with each other. * If two processes run the same test at the same time, they could interfere with each other. After ----- * Writes example file to `/tmp/VersionCheck-NNNNNNN/versionCheckTestFile.json` * Temp folder cleaned up at end * If two users or two processes run the test, they use separate folders
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a small change to the way the tests run. It doesn't change the meaning of the test.
Before
/tmp/versionCheckTestFile.json.After
/tmp/VersionCheck-NNNNNNN/versionCheckTestFile.json