CiviUnitTestCase (etal) - Resolve spooky interaction

[totten]

Overview

In #25673, there was a spooky interaction between tests -- which originated in a subtle detail of the setUp() process.

That PR includes the minimal change. This PR aims to be more proactive -- normalizing the setUp() and (hopefully) preventing similar spookiness in the future.

Before

Four tests in api_v3_* use this uncommon formulation:

   protected function setUp(): void {
     $this->useTransaction(TRUE);
     parent::setUp();
   }

After

The tests now match their 54 siblings in api_v3_* which use:

   protected function setUp(): void {
     parent::setUp();
     $this->useTransaction(TRUE);
   }

Anything with a flipped sequence will raise an error.

Comments

I only looked at tests/phpunit/api/v3. The testbot should now complain about similar issues in other suites.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Sounds like it might fail a few times before it passes but good to merge when it does

[totten]

After looking at the other suites, the notion of "common" and "uncommon" changed, but (so far) not enough to change the approach.

Suite	Tends to use	Comment
api3	setUp()=>useTransaction()	Very strong trend
CRM	useTransaction()=>setUp()	Moderately strong trend
Civi	Both	50/50 split
api4	TransactionalInterface	Very strong trend. Internally, it looks analogous to setUp()=>useTransaction(), but the names are different.

Going literally and by pure numbers, setUp()=>useTransaction() has the edge. If you count TransactionalInterface as its behavioral cousin, then it's clearly the more common behavior.

(Full transparency: I don't have a sense for either order being intrinsically better than the other. But standardizing should make things more predictable/consistent, and it should be easier to standardize on the behavior that's more common. 🤞 And it fixed the flakiness on the locking PR.)

[eileenmcnaughton]

Yeah - I don't care either way - I generally find the useTransaction kinda hard to work with (cos I can't check the database while stepping through it) - but am agnostic about the order of those 2 statements where we are using it

[totten]

I'm gonna downgrade this to "merge ready". We want to make sure that #25673 passes for the right reasons, and it might be best to merge this after that one is settled.