[REF][PHP8.2] Get rid of dynamic properties in CRM_Core_Payment_ProcessorFormTest #25844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
76f7cb9 to
73169b3
Compare
73169b3 to
f01f21a
Compare
|
This was draft but I see you fixed the test errors & it all looks good so I'm assuming you just forgot to de-draft it - so I did so & am mergeing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Get rid of dynamic properties in CRM_Core_Payment_ProcessorFormTest
Before
Use of dynamic properties causes tests to fail on PHP 8.2.
After
Properties declared for greater PHP 8.2 compatiability.
I've also renamed the properties to make it clearer what they contain (IDs)