[REF][PHP8.2] Declare property in CRM_Contact_Form_DedupeFind

[braders]

Overview

Declare property in CRM_Contact_Form_DedupeFind.

Before

$rgid declared as a dynamic property. Dynamic properties are deprecated in PHP 8.2.

After

Property declared.

Technical Details

Technically speaking this is a breaking change as we've now made rgid protected, and an extension could be reading it via a hook like https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_preProcess/. That said, in this case I think the chance of an extension being impacted is very small. It's also easy for an impacted extension to just read the value directly from CRM_Utils_Request::retrieve('rgid', 'Positive', $this, FALSE, 0); if needed.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Yep agree - I don't think extensions should be treating every property or function as available to them.