Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report missing triggers if the user cannot check them #25820

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 15, 2023

Overview

This disables the new SystemCheck (in master /5.61) where it is not possible to accurately determine if the triggers exist

image

Before

If the database user does not have permission to see the triggers it gets the error

After

If the database user does not have permission to see the triggers the check is short-circuited

Technical Details

I also removed the word Experimental from the setting that determines this

Comments

@civibot
Copy link

civibot bot commented Mar 15, 2023

(Standard links)

@civibot civibot bot added the master label Mar 15, 2023
@eileenmcnaughton eileenmcnaughton merged commit 68c69c0 into civicrm:master Mar 15, 2023
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy

@eileenmcnaughton eileenmcnaughton deleted the sql_cache branch March 15, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants