Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to search kits to import preview screen, when Civ-Import is enabled #25816

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Add links to search kits to import preview screen, when Civ-Import is enabled

Before

It's kinda hard to figure out what went wrong cos the whole Download spreadsheet process is a bit of a pain

image

After

the errors links are 'See Errors' not Download Errors & ff Civi-Import is enabled & go to the relevant Import Search. In addition there is a link to see the unfiltered list ('See Rows'). We used See Errors earlier on the Summary screen

image

Technical Details

I mostly did this cos when doing development it removes a pain point - hence I have also just done for Contribute import at the moment - unfortunately the Preview.tpl files need a sync pass & probably can be squashed into a shared file, at which point the links apply to all Preview screens

One challenge is these links should open in a new tab whereas the standard one shouldn't - this addresses that using another variable

Comments

@civibot
Copy link

civibot bot commented Mar 15, 2023

(Standard links)

@civibot civibot bot added the master label Mar 15, 2023
@eileenmcnaughton eileenmcnaughton merged commit 4b663bb into civicrm:master Mar 15, 2023
@eileenmcnaughton eileenmcnaughton deleted the import_sk branch March 15, 2023 02:04
@eileenmcnaughton eileenmcnaughton restored the import_sk branch March 15, 2023 02:04
@eileenmcnaughton eileenmcnaughton deleted the import_sk branch March 15, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants