-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cache clearing when import table is changed #25774
Fix cache clearing when import table is changed #25774
Conversation
(Standard links)
|
CRM/Core/BAO/UserJob.php
Outdated
@@ -146,7 +146,7 @@ public static function getStatuses(): array { | |||
* @return array | |||
*/ | |||
public static function getTypes(): array { | |||
$types = Civi::cache()->get('UserJobTypes'); | |||
$types = Civi::cache('metadata')->get('UserJobTypes'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only thought this was relevant - but we should use the metadata
cache here for consistency
cdfd13f
to
8ce6eb0
Compare
@totten should this be merge on pass or do we need to wait a few more days after having group-discussed |
@eileenmcnaughton Don't have to wait for a few days. I flagged Aside: for the test fail, here's a targetted rerun: https://test.civicrm.org/job/CiviCRM-Manual-Test/47/ |
216b80d
to
580aee7
Compare
580aee7
to
9e949f8
Compare
It went stale during that test run - rebased |
This is passing so merging as discussion suggests it really is merge-on-pass |
Overview
Fix cache clearing when import table is changed
Before
Civi-Import
After
The cache is cleared whenever the table is changed, test coverage
Technical Details
We were clearing the cache on create & delete, but not when the table was updated - which meant we could hit errors when the cache was trying to access a now-deleted table
Comments