Fix typing, comments in new StandardFilters class #25730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Looks like an ephemeral worker was preempted during test execution, so that one failure was probably a false-negative. Requested a re-run of that suite: https://test.civicrm.org/job/CiviCRM-Manual-Test/46/ Merge on pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix typing, comments in new StandardFilters class
Before
After merging https://github.com/civicrm/civicrm-core/pull/25727/files#diff-fa6af4a0aa5d42524fadaa8f5e4b1176da2475ce01f03e9e3a2ffe78d8a64a5cR6 for @totten I spotted a problem with code comments & also a lack of types / return hints
After
Technical Details
I held off marking them as inspections to ignore cos I don't think we should. I type hints might not bubble up nicely though - so they probably should throw exceptions if not string
Comments