dev/core#3438 Drupal: Prevent cv fatal if logging before CMS bootstrap #25728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
|
makes sense to me @demeritcowboy ? |
|
I was just testing based on the new info in the lab ticket. It occurs to me when CIVICRM_DEBUG_LOG_QUERY is set this generates an enormous amount of junk in drupal watchdog, but can think about that as a followup. |
|
I don't mean the PR generates the junk, I mean the combination of the two settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/-/issues/3438
When using "Log to Drupal watchdog", using
cvmight fatal when logging.To reproduce:
cv api system.checkBefore
Fatal : " \Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container. "
After
no fatal
Technical Details
Copied an ugly workaround used elsewhere for i18n, from back in the days of
rest.php(when the CMS is manually bootstrapped).