Pager missing on Aggregate By Relationship civireport #25721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Pager is missing
Before
After
Pager works.
Technical Details
The way setPager() works is it looks at the last query that was run and asks mysql how many rows it was. But in this report the
$this->_limit
is needed in the query. So we need to have the query get the full number of rows before calling setPager.Comments
FYI @yashodha you might have some interest.