Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated code removal #25710

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 2, 2023

Overview

Removes code that's been noisily deprecated > 3 years; ensures more recently noisy deprecations have an accompanying @deprecated annotation.

@civibot
Copy link

civibot bot commented Mar 2, 2023

(Standard links)

@civibot civibot bot added the master label Mar 2, 2023
@totten
Copy link
Member

totten commented Mar 2, 2023

Searched universe for several of these and agree they aren't used: pendingToConfirmSpaces(), _html2pdf_tcpdf(), and (fromCRM_Utils_System) urlEncode() and relativeURL().

I didn't check the bits in CRM/Event/Form/Participant.php.

@eileenmcnaughton
Copy link
Contributor

I confirmed the 2 bits that were not listed above have been deprecated since early 2020 - I didn't double check the deprecation dates on the functions being removed since I think doing EITHER a check on when the noisy deprecation was added OR a universe check is appropriate & the universe check is done per the comments above

@eileenmcnaughton eileenmcnaughton merged commit b8df447 into civicrm:master Mar 2, 2023
@eileenmcnaughton eileenmcnaughton deleted the deprecatedGone branch March 2, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants