Stop passing invariable variables to private function

[eileenmcnaughton]

Overview

Stop passing invariable variables to private function

Before

This previously shared function is called from 2 places. In both cases there are a number of hard-coded variables that are the same

After

Hard-coding moved to within function (most of them could be fully removed but I've excluded that change to keep the PR readable & focus on the inputs of the function). Handling for invalid permissions value removed as it is now always valid

Technical Details

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

This looks good and I see more cleanup can be done now that the variables never change.