Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php8.2 test fix, remove one instance of undeclared property #25619

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Php8.2 test fix, remove one instance of undeclared property #25619

merged 1 commit into from
Feb 19, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Minor tidy up + remove $this->_ids['price_set'] = $priceSet->id; since it isn't a property & isn't used elsewhere

@civibot
Copy link

civibot bot commented Feb 18, 2023

(Standard links)

@civibot civibot bot added the master label Feb 18, 2023
@eileenmcnaughton eileenmcnaughton changed the title Php8.2 test fix, remove one instance on undeclared parameter Php8.2 test fix, remove one instance of undeclared property Feb 18, 2023
@eileenmcnaughton eileenmcnaughton force-pushed the php82_test branch 8 times, most recently from 4414766 to 24e6636 Compare February 19, 2023 01:49
@eileenmcnaughton eileenmcnaughton merged commit e29ccb0 into civicrm:master Feb 19, 2023
@eileenmcnaughton eileenmcnaughton deleted the php82_test branch February 19, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001