Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove always-NULL $singleRecord variable #25519

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove always-NULL $singleRecord variable

Before

Per #25517 $singleRecord is always NULL so

  1. the removed condition renders to NULL != 'new & is always TRUE
  2. the value passed to the second function is always NULL, which is the default for the parameter so we don't pass it

After

extraneous usage removed

Technical Details

This can be merged separately from #25517 as that PR 'makes the case' but is not required for this to be TRUE. There is other follow on cleanup to do on other parameters so the variables will get flushed out then if need be

Comments

@civibot
Copy link

civibot bot commented Feb 7, 2023

(Standard links)

@civibot civibot bot added the master label Feb 7, 2023
@yashodha
Copy link
Contributor

@eileenmcnaughton merging this PR

@yashodha yashodha merged commit 327bb32 into civicrm:master Feb 10, 2023
@eileenmcnaughton eileenmcnaughton deleted the gettree2 branch February 10, 2023 03:44
@eileenmcnaughton
Copy link
Contributor Author

thanks @yashodha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants