Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception type in upgrade snapshot #25480

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

demeritcowboy
Copy link
Contributor

Overview

This was just merged in #25420 but it's not the right type.

Before

No exceptions get caught.

After

Puts it back like it was before #25420 where exceptions get caught.

Technical Details

There's only a handful of things that can go wrong in this query:

  1. DB error => PEAR_Exception
  2. Aliens arrive and are friendly, in which case will have an advanced version of civi you can use instead.
  3. Aliens arrive and are not friendly, in which case you will have more important things to worry about than upgrading civi.

Comments

@civibot
Copy link

civibot bot commented Jan 31, 2023

(Standard links)

@eileenmcnaughton
Copy link
Contributor

thanks @demeritcowboy

@eileenmcnaughton eileenmcnaughton merged commit 0e56db7 into civicrm:master Jan 31, 2023
@demeritcowboy demeritcowboy deleted the err branch February 1, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants