CaseActivityTest - Fix quiet regressions #25416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Following eb92dd7, the `CaseActivityTest` started to run only intermittently. Why? __high-level__: `Civi\Core\ClassScanner` and `phpunit8` both do a scan over the folder `tests/phpunit/CRM/Case/WorkflowMessage` __low-level__: `Civi\Core\ClassScanner` has caching. Depending on the state of the cache, it may or may not do a scan: * If the cache is filled, then `ClassScanner` doesn't need to scan. * When `phpunit8` subsequently does a scan, it will load `CaseActivityTest.php` normally. * If the cache is empty, then `ClassScanner` does the first scan. It is the one that actually loads `CaseActivityTest.php`. * Later, `phpunit8` does a scan. Due to a quirk, it doesn't realize the class exists. The scanner in phpunit works roughly like this: ```php $tests = []; foreach (glob('*Test.php') as $file) { $before = get_declared_classes(); require_once $file; $after = get_declared_classes(); $tests = array_merge($tests, array_diff($before, $after)); } ``` So if the class was previously loaded, then phpunit doesn't see it.
The relevant example data was changed by 98e528a.
bf7329f to
4c9783f
Compare
|
civibot, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After eb92dd7,
CaseActivityTeststopped running reliably. After 98e528a, one of the assertions started failing.Depends: #25415
Before
Test does not run consistently.
After
Test runs and passes.
Comments
More details in commit notes