CiviEvent - Fix missing default values for required fields in event registration setup

[larssandergreen]

Overview

#24863 caused a regression so that the default values were no longer set for the required fields on the Online Registration tab when configuring an event (as noted on Stack Exchange). The cause was that the default values were being set to null from API4 whereas previously the array keys did not exist.

I replaced all uses of Civi_Util_Array:value with ?? in this function. I also made the Registration Link Text required, which seems to be the original intent (if you don't enter a value, the default is used anyways). If this wasn't changed, there would be odd behaviour if the field was set to nothing, resulting in it being re-filled with the default.

Before

No default values, which is annoying because you are still forced to enter a title for the confirmation screen even if it is disabled.

After

Default values loaded as before.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks @larssandergreen can you put against 5.58?

[demeritcowboy]

Fun with git. You'll need to do something like

git fetch upstream 5.58
git rebase upstream/5.58

where upstream is the real civi repo.

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

test this please

[totten]

I did some r-run and confirmed the defaults worked better.

There were test failures in CRM_Event_Form_ManageEvent_RegistrationTest. Pushed up a commit which should address that.

[larssandergreen]

I didn't see the test failures, but looking at CRM_Event_Form_ManageEvent_RegistrationTest I suspect I just need to add the newly required field to the test data, which I've just done.

[totten]

Thanks @larssandergreen. Applied the same to the backport.

[totten]

Test failures are unrelated.