CustomFields - Drop unused column 'mask'

[colemanw]

Overview

Drops a column which doesn't appear to be used for anything.

Before

mask is added to the CRM/Custom/Form/Field.php quickform but never printed in the corresponding CRM/Custom/Form/Field.tpl, and does not appear to be used anywhere else. I don't see any reference to it in CRM_Core_BAO_CustomField when the custom fields actually get rendered.

After

Buh bye.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@colemanw Is this something some extensions could have used may be?

[colemanw]

@yashodha I searched through universe and couldn't find it used anywhere.

[yashodha]

@colemanw merging this PR.

[MegaphoneJon]

This breaks upgrades when advanced logging is enabled (and I would guess possibly multilingual). I think the dropColumn function needs to immediately update the logging schema and rebuild triggers. I'll open a Gitlab ticket.

[seamuslee001]

hmm @MegaphoneJon so similar to this patch #25421 but slightly different context but same problem right?

[MegaphoneJon]

@seamuslee001 Yes, that's correct. I think maybe alterColumn and dropColumn should have those lines themselves rather than relying on their being added to the upgrade step.

[colemanw]

I'd be ok with adding the logging/schema/rebuild functionality to dropColumn and maybe alterColumn. I agree it would benefit long-term stability but might cause some short-term upset if we don't thoroughly check all the places those functions are used and verify the change is ok.