Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined array keys on case activity view #25381

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Undefined array keys on case activity view #25381

merged 1 commit into from
Jan 20, 2023

Conversation

demeritcowboy
Copy link
Contributor

Overview

This isn't even php 8 I'm writing a unit test and these are coming up.

Before

  1. Create a case.
  2. Turn on debugging at Administer - System Settings - debugging.
  3. Turn off popups at Administer - Customize - Display prefs, or in step 4 open in a new tab.
  4. View a case activity.
  5. Red box with smarty notices.

After

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jan 19, 2023

(Standard links)

@civibot civibot bot added the master label Jan 19, 2023
@demeritcowboy
Copy link
Contributor Author

jenkins retest this please

@yashodha
Copy link
Contributor

@demeritcowboy looks good, merging this PR. Thanks!

@yashodha yashodha merged commit a89de0a into civicrm:master Jan 20, 2023
@demeritcowboy demeritcowboy deleted the case-act-vars branch January 20, 2023 17:12
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demeritcowboy @yashodha