dev/core#4088 Superficial cleanup on Api4testBase #25378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
a95decb to
5e543bf
Compare
|
Test fail highlights why we should add type hints BEFORE the class is more broadly accessible Fatal error: Declaration of api\v4\Action\ContactIsDeletedTest::setUpHeadless() must be compatible with api\v4\Api4TestBase::setUpHeadless(): Civi\Test\CiviEnvBuilder in |
|
afform ContactSummaryTest also needs the type hint. |
5e543bf to
9f374c9
Compare
9f374c9 to
f76dfa8
Compare
|
thanks @demeritcowboy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly tighting hints & docblocks & using single quotes where possible (more quote consistency = more greppable & also makes it clearer when there IS a reason for double quotes)