[REF][PHP8.2] Avoid dynamic properties in api_v3_EventTest #25375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
braders
commented
Jan 18, 2023
| @@ -82,9 +92,6 @@ public function setUp(): void { | |||
| } | |||
|
|
|||
| public function tearDown(): void { | |||
| foreach ($this->eventIds as $eventId) { | |||
| $this->eventDelete($eventId); | |||
There was a problem hiding this comment.
This code was never being reached as eventIds was the wrong property. It's also unnecessary as the event and participant tables are truncated a couple of lines down!
Aaah, thanks for explaining. That makes perfect sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Avoid dynamic properties in api_v3_EventTest, as dynamic properties are deprecated in PHP8.2
Before
This class was a bit of a mess.
_eventsand_eventIdswere being used with a mixture of leading underscore and no leading underscore, and neither version was explicitely declared. Whilst the tests were actually working correctly, it meant some of the code was not running quite as originally expected.After
_eventsand_eventIdsare explicitely declared, no longer dynamic.I've stuck with the leading underscore (even though I'm not the fan) as these were the params in most frequent use throughout the class.