Fix dev/core#4083 - Broken autocomplete Afform widget #25374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Merging based on testing from @briennekordis, who reported on Gitlab: "Just tried that patch and it fixed the issue for me." |
colemanw
added a commit
to colemanw/civicrm-core
that referenced
this pull request
Apr 5, 2023
There was some back-and-forth with this. civicrm#25374 removed the change() trigger, which fixed the recursion bug described in https://lab.civicrm.org/dev/core/-/issues/4083 but broke setting defaults, prompting civicrm#25465 which proposed to change it back. This fix walks the line by triggering the change event but only when the value has actually changed. Fixes dev/core#4110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes bug in https://lab.civicrm.org/dev/core/-/issues/4083
Before
Afforms using "Existing Entity" widgets are broken with endless console errors.
After
Fixed.