[REF][PHP8.2] Use const instead of dynamic property: CRM_Contribute_BAO_ContributionPageTest #25372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AO_ContributionPageTest
|
(Standard links)
|
|
Test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use const instead of dynamic property in CRM_Contribute_BAO_ContributionPageTest
Before
A dynamic property was being used to ensure a consistent ID was used across tests. Dynamic properties are deprecated in PHP8.2 The value was hardcoded and never changed.
After
Use a
constinstead, this text will run cleanly on PHP 8.2Comments
It's a test so backwards compatiability risk is very low.