Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#4084) Assign participant_status_id in both edit/create modes #25366

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

yashodha
Copy link
Contributor

Overview

Assign participant_status_id in both edit/create modes

Before

We don't have participant_status_id assigned in create mode only edit mode.

After

We have participant_status_id assigned in both create and edit modes.

@civibot
Copy link

civibot bot commented Jan 17, 2023

(Standard links)

@civibot civibot bot added the master label Jan 17, 2023
@eileenmcnaughton
Copy link
Contributor

@yashodha I agree with this change - but are you wanting to make it for form-layer or message-template layer purposes (if the latter then using a token might be more robust long-term)

@eileenmcnaughton
Copy link
Contributor

test this please

@yashodha
Copy link
Contributor Author

yashodha commented Jan 18, 2023

@yashodha you are right. Assigning participant_status_id just for edit mode seems off so fixing the behavior here.

@eileenmcnaughton eileenmcnaughton merged commit 79ac44c into civicrm:master Jan 18, 2023
@eileenmcnaughton
Copy link
Contributor

@yashodha this smarty assign doesn't seem to be used in core anywhere - so we probably should have removed it rather than assigned it more? I'm thinking you wanted it for an extension? Maybe we can talk about how to do it in the extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants