Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF][PHP8.2] Fix creation of dynamic properties in Payflow Pro exten… #25355

Merged
merged 1 commit into from
Jan 17, 2023
Merged

[REF][PHP8.2] Fix creation of dynamic properties in Payflow Pro exten… #25355

merged 1 commit into from
Jan 17, 2023

Conversation

seamuslee001
Copy link
Contributor

…sion

Overview

Similar to #25353 but for the Payflow Pro extension

Before

Tests fail on PHP8.2

After

Tests pass on PHP8.2

ping @demeritcowboy @eileenmcnaughton @braders

@civibot
Copy link

civibot bot commented Jan 15, 2023

(Standard links)

@civibot civibot bot added the master label Jan 15, 2023
@eileenmcnaughton
Copy link
Contributor

Same as Elavon - seems safe enough although I'd rather figure out how to make these extensions non-php8.2 compatible

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

1 similar comment
@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@seamuslee001
Copy link
Contributor Author

Test fails unrelated

@seamuslee001 seamuslee001 merged commit 126bad7 into civicrm:master Jan 17, 2023
@seamuslee001 seamuslee001 deleted the fix_payflow_pro branch January 17, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton