Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(REF) Tidy up of CRM_Extension_ManagerTest #25350

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 15, 2023

Overview

This is a general tidy up of CRM_Extension_ManagerTest. The driving motivation is removing dynamic properties for PHP8.2 support, but in this case the refactoring goes slightly further.

Similar to PR #25349

Before

  1. Properties were not declared (i.e. were dynamic and deprecated)
  2. A couple of methods were unnecessarially public
  3. Tests were setting and getting $this->download, but the value was never shared between tests; a local variable is better suited.
  4. _createContainer was taking cache arguments, but _createContainer was never called with arguments. The arguments were not necessary.

After

The above issues tidied up, and no dynamic properties remain in this class.

@civibot
Copy link

civibot bot commented Jan 15, 2023

(Standard links)

@civibot civibot bot added the master label Jan 15, 2023
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor

I agree this is a code improvment (& addresses php 8,2)

@eileenmcnaughton eileenmcnaughton merged commit dfde239 into civicrm:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants