(REF) Tidy up of CRM_Extension_ManagerTest #25350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a general tidy up of
CRM_Extension_ManagerTest
. The driving motivation is removing dynamic properties for PHP8.2 support, but in this case the refactoring goes slightly further.Similar to PR #25349
Before
public
$this->download
, but the value was never shared between tests; a local variable is better suited._createContainer
was taking cache arguments, but_createContainer
was never called with arguments. The arguments were not necessary.After
The above issues tidied up, and no dynamic properties remain in this class.