Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.2] Avoid dynamic properties in module tests #25348

Merged

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 15, 2023

Overview

Avoid dynamic properties in module tests

Before

basedir and system were used as dynamic properties, not declared.

After

The properties are declared, we move closer to PHP8.2 support.

See https://lab.civicrm.org/dev/core/-/issues/3833

@civibot
Copy link

civibot bot commented Jan 15, 2023

(Standard links)

@civibot civibot bot added the master label Jan 15, 2023
@eileenmcnaughton eileenmcnaughton merged commit 27faf6f into civicrm:master Jan 15, 2023
@eileenmcnaughton
Copy link
Contributor

Yep - as with other abbreviatsions basedir can be challenging for non-English speakers to interpret (probably with camel case they would be able to guess dir = Directory) - but that is unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants