Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise Type on includedGroups parameter #25330

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Standardise Type on includedGroups parameter

Before

I had to read through the function to determine that passing NULL or [] for $includedGroups had the same outcome (because it is only used if !empty($includedGroups)

After

Parameter standardised as an array, NULL deprecated

Technical Details

The deprecation notice might cause some test fails, which I will address if so

Comments

@civibot
Copy link

civibot bot commented Jan 12, 2023

(Standard links)

@civibot civibot bot added the master label Jan 12, 2023
@demeritcowboy
Copy link
Contributor

  • General standards
    • [r-explain] NULL
    • [r-user] NULL
    • [r-doc] array
    • [r-run] (array) NULL
  • Developer standards
    • [r-tech] 'null'
    • [r-code] array
    • [r-maint] NULL
    • [r-test] NULL

@eileenmcnaughton eileenmcnaughton deleted the acl_api branch January 15, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants