Standardise Type on includedGroups
parameter
#25330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Standardise Type on
includedGroups
parameterBefore
I had to read through the function to determine that passing
NULL
or[]
for$includedGroups
had the same outcome (because it is only used if!empty($includedGroups)
After
Parameter standardised as an array, NULL deprecated
Technical Details
The deprecation notice might cause some test fails, which I will address if so
Comments