-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dev/core#4074) Make CRM_Core_BAO_CMSUser CMS agnostic #25323
Conversation
(Standard links)
|
jenkins retest this please |
Can one of the admins verify this patch? |
Turns out I've got a Backdrop-related bug to fix as well, which would benefit from this being merged first and built on top. (I may have to make it a separate PR and rework it again if/when this PR gets merged). Any interest in reviewing? @demeritcowboy @eileenmcnaughton |
Sure I can take a look just probably won't be until the weekend. |
Thank you @demeritcowboy! |
@demeritcowboy This is my follow-up to this one: #25371 (or could be done first if this one gets stuck). |
Oops. I accidentally closed this PR. I'll see if I can update/reopen it or I'll create a replacement. |
Ah git. The old state of the tree should still be at cd46160, e.g. https://github.com/civicrm/civicrm-core/tree/cd46160, if needed. |
@demeritcowboy thank you. Tests are now running again. |
@demeritcowboy this has passed now - it looks like your review has been addressed? |
I didn't fully review it the first time and haven't re-reviewed this yet after being combined with the other PR. |
|
Fixes https://lab.civicrm.org/dev/core/-/issues/4074. Splits up the logic into each CMS in the userSystem. This functionality is used when using a profile to create a user account.
I've tested it with creating a user account and also checking the username which happens via ajax on the profile (on Drupal 9). Both still work.