Pass metadata values rather than convoluted array to processCustomFields
#25318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
test this please |
2 similar comments
|
test this please |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Pass metadata values rather than convoluted array to
processCustomFieldsBefore
processCustomFieldsreceives a complex array which has been obtained from a legacy functionAfter
By switching to passing in the actual values we can start to use an api call rather than a legacy function to load the metadata
Technical Details
As with a lot of CiviCRM code the code around this is bending over backwards to pack & unpack a particular array structure that is dated & not in keeping with a more api-v4-oriented approach
Comments
Code is heavily tested