Fix Undefined index: name Notice in civicrm_api3_message_template_send #25288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
test this please |
|
My general feeling here is we should create a good v4 api for email & focus our energy there - which means that my feeling on this is 'if it makes the notice go away then OK' |
|
@eileenmcnaughton yes, I agree re good api for email on api4. Thanks for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumed that each item of the spec had a 'name' key, but this not so.
(I think this PR is the fix. I do wonder why you need 'name' though here - could use
$field?)Tagging @eileenmcnaughton as came in in this commit: cac79b2